Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Embed the Vale Google package in writing-rules #227

Open
alexfauquette opened this issue Feb 21, 2024 · 1 comment
Open

[docs-infra] Embed the Vale Google package in writing-rules #227

alexfauquette opened this issue Feb 21, 2024 · 1 comment
Assignees
@alexfauquette
Labels
scope: docs-infra Specific to the docs-infra product

Comments

@alexfauquette
Copy link
Member

alexfauquette commented Feb 21, 2024 •
edited by github-actions bot
Loading

Is it possible to embed the Google package in docs/writing-rules.zip?

Originally posted by @Janpot in mui/material-ui#41176 (comment)

Search keywords:

Search keywords:
@alexfauquette alexfauquette self-assigned this Feb 21, 2024
@alexfauquette alexfauquette added the scope: docs-infra Specific to the docs-infra product label Feb 21, 2024
@alexfauquette alexfauquette mentioned this issue Feb 21, 2024
Merged
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 17, 2024 •
edited
Loading

I tried in mui/material-ui#41516. It's possible to embed Google rules in a MUI vale package, but then I wasn't able to disable rules as a consumer of it. I gave up. It felt like a bug.

@oliviertassinari oliviertassinari changed the title [docs-infra] Embed the Google package in writing-rules [docs-infra] Embed the Vale Google package in writing-rules Nov 1, 2024
@oliviertassinari oliviertassinari transferred this issue from mui/material-ui Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexfauquette alexfauquette

Labels
scope: docs-infra Specific to the docs-infra product
Projects
Docs-infra
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @alexfauquette