Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Improve visual screenshot environment #199

Open
oliviertassinari opened this issue Sep 13, 2024 · 0 comments
Open

[code-infra] Improve visual screenshot environment #199

oliviertassinari opened this issue Sep 13, 2024 · 0 comments
Labels
enhancement This is not a bug, nor a new feature scope: code-infra Specific to the core-infra product status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 13, 2024 •
edited
Loading

Summary

We recently improved the <TestViewer> component in Material UI mui/material-ui#43743. I believe we should fix the other repositories too:

Now, the right solution is to abstract that logic. It shouldn't be duplicated.

Examples

No response

Motivation

No response

Search keywords: -
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This is not a bug, nor a new feature scope: code-infra Specific to the core-infra product status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oliviertassinari