Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: list-item: basic implementation #694

Closed
wants to merge 2 commits into from
Closed

Conversation

cgestes
Copy link
Contributor

@cgestes cgestes commented May 26, 2015

Basic implementation of list-item. For review and comments.

@freeslugs
Copy link
Contributor

@cgestes can you post an image of an example of your changes? eager to see what you've done visually.

@cgestes
Copy link
Contributor Author

cgestes commented May 27, 2015

2015-05-27-085023_1600x900_scrot

Nothing fancy atm..
the idea is more to gather ideas/comments about what and how to implement list in material-ui.

@cgestes
Copy link
Contributor Author

cgestes commented May 27, 2015

I have a ListHeader too, but not pushed.

@jkruder
Copy link
Contributor

jkruder commented May 28, 2015

I would model it after the list in Material Design. I like the primary/secondary action sections - I would vote to make them elements so the developer can specify whatever s/he wants.

Single, double, triple line variants on the list item are important; maybe a 'type' property similar to the different menu types.

@soda29
Copy link

soda29 commented Jun 1, 2015

Really useful!

@freeslugs
Copy link
Contributor

I think the bottom border should be optional (probably thinner and closer to google's design), and let's try to center the icons in the list better. keep up the great work, eager to get this merged 😄
reference: http://www.google.com/design/spec/components/lists.html#lists-specs

@hai-cea
Copy link
Member

hai-cea commented Jun 5, 2015

@cgestes Thanks for getting this started. This has been a component that have been high on our priority because it is the root element for a few other components that we'd like to redo - like menus, dropdowns, navs.

I'd like to merge your code in and take it over to finish it out. What are your thoughts?

@cgestes
Copy link
Contributor Author

cgestes commented Jun 9, 2015

This piece of code really needs more work. It is not very useful as it is. Feel free to merge in and improve, but it's ok if it's not merge as it is.

I will improve it slowly.

To be done property it seems that we need flex containers.

@hai-cea
Copy link
Member

hai-cea commented Jun 13, 2015

Replaced by #836

@hai-cea hai-cea closed this Jun 13, 2015
@zannager zannager added the component: list This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants