-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: list-item: basic implementation #694
Conversation
@cgestes can you post an image of an example of your changes? eager to see what you've done visually. |
I have a ListHeader too, but not pushed. |
I would model it after the list in Material Design. I like the primary/secondary action sections - I would vote to make them elements so the developer can specify whatever s/he wants. Single, double, triple line variants on the list item are important; maybe a 'type' property similar to the different menu types. |
Really useful! |
I think the bottom border should be optional (probably thinner and closer to google's design), and let's try to center the icons in the list better. keep up the great work, eager to get this merged 😄 |
@cgestes Thanks for getting this started. This has been a component that have been high on our priority because it is the root element for a few other components that we'd like to redo - like menus, dropdowns, navs. I'd like to merge your code in and take it over to finish it out. What are your thoughts? |
This piece of code really needs more work. It is not very useful as it is. Feel free to merge in and improve, but it's ok if it's not merge as it is. I will improve it slowly. To be done property it seems that we need flex containers. |
Replaced by #836 |
Basic implementation of list-item. For review and comments.