-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DatePicker] Migrate to the lab #22692
Conversation
Bumps [babel-plugin-optimize-clsx](https://github.com/merceyz/babel-plugin-optimize-clsx) from 2.5.0 to 2.6.0. - [Release notes](https://github.com/merceyz/babel-plugin-optimize-clsx/releases) - [Changelog](https://github.com/merceyz/babel-plugin-optimize-clsx/blob/master/CHANGELOG.md) - [Commits](merceyz/babel-plugin-optimize-clsx@v2.5.0...v2.6.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [dayjs](https://github.com/iamkun/dayjs) from 1.8.17 to 1.8.21. - [Release notes](https://github.com/iamkun/dayjs/releases) - [Changelog](https://github.com/iamkun/dayjs/blob/dev/CHANGELOG.md) - [Commits](iamkun/dayjs@v1.8.17...v1.8.21) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [babel-plugin-optimize-clsx](https://github.com/merceyz/babel-plugin-optimize-clsx) from 2.5.0 to 2.6.0. - [Release notes](https://github.com/merceyz/babel-plugin-optimize-clsx/releases) - [Changelog](https://github.com/merceyz/babel-plugin-optimize-clsx/blob/master/CHANGELOG.md) - [Commits](merceyz/babel-plugin-optimize-clsx@v2.5.0...v2.6.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) from 16.12.0 to 16.13.0. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/master/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v16.13.0/packages/react) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.0.7 to 10.0.8. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v10.0.7...v10.0.8) Signed-off-by: dependabot-preview[bot] <[email protected]>
* Rename MuiPickersUtilsPorvider => LocalizationProvider * Improve utils typings * Implement global format override * [docs] Change name of date-io customization page * Update examples to include new wording * Fix prop-types typescript error * Add daetAdapter prop for passing date-io utils directly to component * Update percy and cypress * Unskip flaky test * Fix typo in error message * Fix cypress test * One more try to fix flaky test * Remove flaky test * Fix visual regression scenarios tests with new version of cypress * Run cypress tests in chrome * Ignore dark theme change in snapshots * Try to fix example styles one more time * Fix inccorect name of cypress executor * Try weird hack to reinject styles * Optimize theme toggling for visual regression * Update scenario names to get rid of duplications * Rename `adapter` => `dateAdapter` * Rename libFormats => dateFormats, libInstance => dateLibInstance * Remove version-specific code from README.md * Fix documentation erros in installation guide * Run prettier on README.md * Use edge="end" for keyboard adornment icons, closes mui#1545
* Make set today button works properly with autoOk * Add tests * Fix autoOK behavior when several views shown
…rial-ui/core-4.9.3 Bump @material-ui/core from 4.8.3 to 4.9.3
Bumps [@material-ui/icons](https://github.com/mui-org/material-ui/tree/HEAD/packages/material-ui-icons) from 3.0.2 to 4.9.1. - [Release notes](https://github.com/mui-org/material-ui/releases) - [Changelog](https://github.com/mui-org/material-ui/blob/master/CHANGELOG.md) - [Commits](https://github.com/mui-org/material-ui/commits/v4.9.1/packages/material-ui-icons) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [jest](https://github.com/facebook/jest) from 24.9.0 to 25.1.0. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](jestjs/jest@v24.9.0...v25.1.0) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [dayjs](https://github.com/iamkun/dayjs) from 1.8.21 to 1.8.22. - [Release notes](https://github.com/iamkun/dayjs/releases) - [Changelog](https://github.com/iamkun/dayjs/blob/v1.8.22/CHANGELOG.md) - [Commits](iamkun/dayjs@v1.8.21...v1.8.22) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Looks good since I see a lot of commits 👍 Now we just have to hope the git surgery goes smoothly |
Scalpel. Forceps... |
Includes all commits from pickers, one commit from git-subtree-add and one commit for integration squashed the work done in #22692 |
Move picker sources into lab (#4) Update README.md [DatePicker] Refactor pickers tests to testing-library and mocha (#5) [TimePicker] Migrate tests to testing library (#8) [DateTimePicker] Migrate tests (#9) Fix all pickers linter errors (#10) Fix all circular dependencies (#11) * Fix all circular dependencies * Enable mocha eslint rules for typescript tests [test] The last step to a green CI (#15) Migrate pickers docs (#12) Downgrade to withStyles for pickers sources (#16) Add public api exports for pickers components (#17) Consolidate component namespace and theme augmentation (#18) Describe conformance for pickers sub-components (#19) Autogenerate proptypes for typescript sources (#20) Proper build output (#21) Clear migration artifacts (#23) Eslint rule for lower-case test name convention (#24) DateRangePicker (#25) yarn deduplicate Remove GridListTile [DateTimePicker] Fix migration unit tests Fix types Fix typescript types migration issues Fix yarn lerna build (#33) Fix karma tests use window.Touch for CI karma tests Remove more outdated diff noise (#34) Replace not valid formats with valid ISO strings Try to fix CI touch tests Skip tests if Touch events are not supported Fix merge conflicts Actually type-check Fix safari tests Remove lowercase test name rule The casing is up to the test author. We're not the grammar police in tests. Fix lint Format Remove overzealous eslint-disable* Debug failing tests Better debugging Timezones are fun was isoString th efix? Let's find out what's failing and then skip it Branch for safari Skip DateRangePicker in browsers review Matt's review Co-authored-by: Matt <[email protected]> format docs:i18n
DONT SQUASH AND MERGE THIS Once this is green and approved I enable merge commits in this repo and merge it with |
This looks almost good. I think that the only part left is to trim pre v4 git history: The argument in favor of only keep v4: the work on-pre v4 isn't relevant. We have reworked significant parts of the logic and will keep doing so. We don't need to go back in the history. This history can be still found on material-ui-pickers, the repository will be archived and accessible indefinitely. |
Every git history is relevant. We don't actually want to discuss whether git is relevant. Let's move forward. |
Could you explain to me what changed in the last few days between me saying I restore the history and now where you're saying we don't need it? |
@eps1lon I have tried to mention it a couple of days ago by updating the pull request description: and in #22692 (comment) before we start doing the rebase, I think that it's complementary :). I guess "first commit" was confusing, it was pointing to the first commit of v4. |
@oliviertassinari I don't see any arguments made against keeping the pre-v4 history, only that keeping even the v4 history was proving challenging. If @eps1lon has solved that (quite how, we may never know! 😄), what's the concern? |
The argument for only keeping v4 onward (about a year of history) is to avoid to include history that we won't be able to leverage. What's the overhead of storing a large git tree? (time to clone, etc?). |
Google seem to manage. Do you have some metrics to demonstrate a problem? |
I thought I could just re-order these compat commits with git-rebase but the visual tool I was using didn't offer that (GitKraken). Moving them via command line sounded too error-prine to me and then I would still have to convert merge commits. Still an interesting exercise but cherry-picking was sufficient here. |
Any potential problem that would arise from 2000 new commits we would have in a year anyway. |
This PR must not be squashed because we will lose all the git history
Edit Olivier: I was aiming to keep all the history of v4, starting with the first commit. However, this has proven to be very challenging to handle (I couldn't figure out how while resolving the merge conflicts). So instead, we have a single commit with Dmitiry as the original author. I think that it's good enough as we will likely still iterate a lot on the logic.Closes #19706
TODO Olivier: