-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React v0.14 #1751
React v0.14 #1751
Conversation
@oliviertassinari why is the build failing? Does this PR need more work before it can be merged? |
@shaurya947 That an issue with npm. I still need to fix it. Well, I would say that we need to fix the docs. |
@oliviertassinari okay. Holding off until issues are fixed. |
@shaurya947 Found my issue, see https://github.com/karlbright/react-stub-context/pull/4. |
Aah gotcha @oliviertassinari |
I'm gonna clone react-stub-context inside mui. We will have to remove it once they support react 14 |
@shaurya947 This should be working now. I'm gonna see If I can fix the docs site. Looks like it's mainly fixing the breaking changes of react-router. |
Do you want me to merge this and you can create a separate PR for the docs site? @oliviertassinari |
@shaurya947 I have fixed the home screen of the docs, however, links are broken, etc, ... |
Thanks @oliviertassinari! Looking forward to a fix with new |
Perfect! I'll be making some pull requests once |
Can help with react-router. I did the transition for my project some days ago. feel free to ping me on gitter. The upgrade doc is well done. I'am also willing to help for testing. Will checkout and test tomorrow. |
That would be much appreciated @cgestes :-) Room on gitter is called |
@cgestes Any idea with the url is Solution : I need createBrowserHistory |
I have the same :) here are some info: remix-run/react-router#1967 |
Do we need all commits for a dev branch to pass all the tests like in master? Maybe it would make sense to merge commits to react-0.14 branch if they look wanted and decent, so that we can try them easily, and provide correction easily. And we take more care that everything is alright before merging to master? |
looks like commit enterred the branch already, forget the previous comment, I'am trying right now :) |
Use #1733.