Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Move size tracking to azure pipelines #16182

Merged
merged 7 commits into from
Jun 13, 2019
Merged

[core] Move size tracking to azure pipelines #16182

merged 7 commits into from
Jun 13, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 12, 2019

Introducing https://dev.azure.com/mui-org/Material-UI

test_build and size_snapshot move from CircleCI to azure pipelines. The UMD smoke test is handled by a new job (test_production).

This will reduce load on CircleCI hoepfully reducing queue times.

TODO:

eps1lon added 5 commits June 12, 2019 18:48
* WIP

* check on non-fork branch

* Full impl

* Dry run

* Rerun

* Look for credentials

* Look again

* The search continues

* Maybe in global scope?

* Inspect env

* Full run

* Dont persist on PR

* Cleanup
* Run danger on azure

* Fix missing danger env variables
* Run size snapshot exclusively on azure

* debug

* Revert "debug"

This reverts commit bff6dd2.

* Fix empty size snapshot being persisted
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 12, 2019

No bundle size changes comparing cddc4cf...92fda69

Generated by 🚫 dangerJS against 92fda69

@eps1lon eps1lon marked this pull request as ready for review June 12, 2019 18:00
@eps1lon eps1lon requested a review from oliviertassinari June 12, 2019 18:00
@eps1lon eps1lon merged commit 151d2f9 into master Jun 13, 2019
@eps1lon eps1lon deleted the azure-pipelines branch June 13, 2019 12:09
@eps1lon
Copy link
Member Author

eps1lon commented Jun 28, 2019

Saved a almost 1 minute (33%) median job time.

mui-azure

Had to crop it manually since circle only displays everything at once. But 3 minutes neatly falls on the y-grid line so this should be fine.

@oliviertassinari
Copy link
Member

Sweet :)

@zannager zannager added the core Infrastructure work going on behind the scenes label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants