Fix table row height in Internet Explorer #1537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What happen if the height of a row is not a constant? |
|
This PR does not deal with that, it simply corrects a bug, since right now it is already in the light theme: https://github.com/callemall/material-ui/blob/master/src/styles/themes/light-theme.js#L168 I simply fixed it to also work in I. I assume people would pass in a style via props if they wish to divert. I don't really mind how the fix is, either remove the existing fixed height and leave it up to the user to specify it at both places, or fix it with this PR to be consistent :) |
|
@CumpsD if this issue still persists with IE, could you please update your branch? We have changed the theming code. Thanks! |
oliviertassinari
added
the
PR: needs revision
Closed
|
@CumpsD Thanks, we have merge your solution 👍. |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* Rename MuiPickersUtilsPorvider => LocalizationProvider * Improve utils typings * Implement global format override * [docs] Change name of date-io customization page * Update examples to include new wording * Fix prop-types typescript error * Add daetAdapter prop for passing date-io utils directly to component * Update percy and cypress * Unskip flaky test * Fix typo in error message * Fix cypress test * One more try to fix flaky test * Remove flaky test * Fix visual regression scenarios tests with new version of cypress * Run cypress tests in chrome * Ignore dark theme change in snapshots * Try to fix example styles one more time * Fix inccorect name of cypress executor * Try weird hack to reinject styles * Optimize theme toggling for visual regression * Update scenario names to get rid of duplications * Rename `adapter` => `dateAdapter` * Rename libFormats => dateFormats, libInstance => dateLibInstance * Remove version-specific code from README.md * Fix documentation erros in installation guide * Run prettier on README.md * Use edge="end" for keyboard adornment icons, closes mui#1545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
Tablefrom v0.11 with a fixed height, all rows were stretched to be the full height in Internet Explorer:This is because Internet Explorer also needs a
heighton thetr.This PR adds the height in the theme, and utilizes it in the
table-row.jsxEnd result: