From 6c69933bc9d1d1c0e82a8c906f3323d97cf22411 Mon Sep 17 00:00:00 2001 From: Olivier Tassinari Date: Sun, 27 May 2018 17:12:26 +0200 Subject: [PATCH 1/4] [ROADMAP] Update the roadmap --- ROADMAP.md | 10 ++++++++++ docs/src/modules/components/Notifications.js | 12 +++++++++--- .../src/pages/demos/snackbars/CustomizedSnackbars.js | 11 ++++++----- docs/src/pages/versions/StableVersions.js | 4 ++-- 4 files changed, 27 insertions(+), 10 deletions(-) diff --git a/ROADMAP.md b/ROADMAP.md index 57565c48630e32..10cd305636717c 100644 --- a/ROADMAP.md +++ b/ROADMAP.md @@ -1,3 +1,13 @@ # Roadmap The roadmap is a living document, and it is likely that priorities will change, but the list below should give some indication of our plans for the next major release, and for the future. + +Our priorities: +1. **Material Design**. The Google Design team has recently released a new iteration on the Material Design specification, it’s focused on *themability*. This is great news! We will do our best to be up to date. It also confirms that heavily investing in customizability for v1 was a good call. We will continue our efforts. +1. **More utils**. We want to work on new utility components: Spacing, Display, Color, etc. +1. **Performance**. We can’t optimize something we can’t measure, and we don’t currently have a CI performance benchmark, so we will need to build one and start investigating bottlenecks. +1. **Learning materials**. The quality of the documentation is equally as important as the quality of the implementation, and while the reference documentation is comprehensive, we could author a learning tutorial like Next.js has done, or an egghead.io course. +Themes. We want to provide common layouts example to make getting started even easier. We also plan on adding more premium themes. +1. **Documentation**. We want to translate the documentation into Chinese and more languages. Any help is welcomed! +1. **Bundle size**. The library needs to be as small as possible, so we need to work on solutions to further reduce the bundle size, for instance, supporting Preact or Nerv can help. +1. **Type checking**. We will continue to improve the TypeScript and maybe the Flow coverage of the library. diff --git a/docs/src/modules/components/Notifications.js b/docs/src/modules/components/Notifications.js index 009c4e052644a3..b510f43c5789d5 100644 --- a/docs/src/modules/components/Notifications.js +++ b/docs/src/modules/components/Notifications.js @@ -1,9 +1,9 @@ /* eslint-disable react/no-danger */ +import 'isomorphic-fetch'; import React from 'react'; import Button from '@material-ui/core/Button'; import Snackbar from '@material-ui/core/Snackbar'; -import 'isomorphic-fetch'; function getLastSeenNotification() { const seen = document.cookie.replace( @@ -43,11 +43,17 @@ class Notifications extends React.Component { message: {}, }; - componentDidMount = async () => { + async componentDidMount() { this.mounted = true; + + // Prevent search engines from indexing the notification. + if (/glebot/.test(navigator.userAgent)) { + return; + } + await getMessages(); this.handleMessage(); - }; + } componentWillUnmout() { this.mounted = false; diff --git a/docs/src/pages/demos/snackbars/CustomizedSnackbars.js b/docs/src/pages/demos/snackbars/CustomizedSnackbars.js index d11a6434bcf27b..2542a16e29555b 100644 --- a/docs/src/pages/demos/snackbars/CustomizedSnackbars.js +++ b/docs/src/pages/demos/snackbars/CustomizedSnackbars.js @@ -2,9 +2,9 @@ import React from 'react'; import PropTypes from 'prop-types'; import classNames from 'classnames'; import Button from '@material-ui/core/Button'; -import CheckIcon from '@material-ui/icons/Check'; -import ErrorOutlineIcon from '@material-ui/icons/ErrorOutline'; -import InfoIcon from '@material-ui/icons/InfoOutline'; +import CheckCircleIcon from '@material-ui/icons/CheckCircle'; +import ErrorIcon from '@material-ui/icons/Error'; +import InfoIcon from '@material-ui/icons/Info'; import CloseIcon from '@material-ui/icons/Close'; import green from '@material-ui/core/colors/green'; import amber from '@material-ui/core/colors/amber'; @@ -15,9 +15,9 @@ import WarningIcon from '@material-ui/icons/Warning'; import { withStyles } from '@material-ui/core/styles'; const variantIcon = { - success: CheckIcon, + success: CheckCircleIcon, warning: WarningIcon, - error: ErrorOutlineIcon, + error: ErrorIcon, info: InfoIcon, }; @@ -38,6 +38,7 @@ const styles1 = theme => ({ fontSize: 20, }, iconVariant: { + opacity: 0.9, marginRight: theme.spacing.unit, }, message: { diff --git a/docs/src/pages/versions/StableVersions.js b/docs/src/pages/versions/StableVersions.js index 016a092596fa2e..74f223703a0085 100644 --- a/docs/src/pages/versions/StableVersions.js +++ b/docs/src/pages/versions/StableVersions.js @@ -49,7 +49,7 @@ class StableVersions extends React.Component { docs: [], }; - componentDidMount = async () => { + async componentDidMount() { const branches = await getBranches(); let docs = branches.map(n => n.name); docs = docs.filter(version => version !== 'latest'); @@ -73,7 +73,7 @@ class StableVersions extends React.Component { // The latest version is always using the naked domain. docs[0].url = 'https://material-ui.com'; this.setState({ docs }); - }; + } render() { const { classes } = this.props; From 6965de0f4008b82d3438b517a39319a520648ef6 Mon Sep 17 00:00:00 2001 From: Olivier Tassinari Date: Sun, 27 May 2018 19:12:07 +0200 Subject: [PATCH 2/4] fix ci --- docs/src/pages/versions/StableVersions.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/src/pages/versions/StableVersions.js b/docs/src/pages/versions/StableVersions.js index 74f223703a0085..6ee9767bc6d54c 100644 --- a/docs/src/pages/versions/StableVersions.js +++ b/docs/src/pages/versions/StableVersions.js @@ -1,3 +1,5 @@ +/* eslint-disable react/no-did-mount-set-state */ + import 'isomorphic-fetch'; import React from 'react'; import PropTypes from 'prop-types'; From 90410fdadd0ddf61ab5e11907c97650a4a311110 Mon Sep 17 00:00:00 2001 From: Olivier Tassinari Date: Sun, 27 May 2018 19:24:00 +0200 Subject: [PATCH 3/4] fix matt feedback --- ROADMAP.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ROADMAP.md b/ROADMAP.md index 10cd305636717c..c3e622d3c888fb 100644 --- a/ROADMAP.md +++ b/ROADMAP.md @@ -7,7 +7,7 @@ Our priorities: 1. **More utils**. We want to work on new utility components: Spacing, Display, Color, etc. 1. **Performance**. We can’t optimize something we can’t measure, and we don’t currently have a CI performance benchmark, so we will need to build one and start investigating bottlenecks. 1. **Learning materials**. The quality of the documentation is equally as important as the quality of the implementation, and while the reference documentation is comprehensive, we could author a learning tutorial like Next.js has done, or an egghead.io course. -Themes. We want to provide common layouts example to make getting started even easier. We also plan on adding more premium themes. +1. **Themes**. We want to provide common layouts example to make getting started even easier. We also plan on adding more premium themes. 1. **Documentation**. We want to translate the documentation into Chinese and more languages. Any help is welcomed! 1. **Bundle size**. The library needs to be as small as possible, so we need to work on solutions to further reduce the bundle size, for instance, supporting Preact or Nerv can help. 1. **Type checking**. We will continue to improve the TypeScript and maybe the Flow coverage of the library. From 28d6c1b9db070487f6b5fee7daa343bf0e74ce4d Mon Sep 17 00:00:00 2001 From: Olivier Tassinari Date: Sun, 27 May 2018 21:23:20 +0200 Subject: [PATCH 4/4] fix matt feedback --- ROADMAP.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ROADMAP.md b/ROADMAP.md index c3e622d3c888fb..f87a7bca6e439a 100644 --- a/ROADMAP.md +++ b/ROADMAP.md @@ -3,11 +3,11 @@ The roadmap is a living document, and it is likely that priorities will change, but the list below should give some indication of our plans for the next major release, and for the future. Our priorities: -1. **Material Design**. The Google Design team has recently released a new iteration on the Material Design specification, it’s focused on *themability*. This is great news! We will do our best to be up to date. It also confirms that heavily investing in customizability for v1 was a good call. We will continue our efforts. +1. **Material Design**. The Google Design team has recently released a new iteration on the Material Design specification which is focused on *themability*. This is great news! We will do our best to keep up to date. It also validates that heavily investing in customizability for v1 was a good call. We will continue our efforts in this area. 1. **More utils**. We want to work on new utility components: Spacing, Display, Color, etc. 1. **Performance**. We can’t optimize something we can’t measure, and we don’t currently have a CI performance benchmark, so we will need to build one and start investigating bottlenecks. 1. **Learning materials**. The quality of the documentation is equally as important as the quality of the implementation, and while the reference documentation is comprehensive, we could author a learning tutorial like Next.js has done, or an egghead.io course. 1. **Themes**. We want to provide common layouts example to make getting started even easier. We also plan on adding more premium themes. -1. **Documentation**. We want to translate the documentation into Chinese and more languages. Any help is welcomed! -1. **Bundle size**. The library needs to be as small as possible, so we need to work on solutions to further reduce the bundle size, for instance, supporting Preact or Nerv can help. -1. **Type checking**. We will continue to improve the TypeScript and maybe the Flow coverage of the library. +1. **Documentation**. We want to translate the documentation into Chinese and other languages. Any help is welcomed! +1. **Bundle size**. The library needs to be as small as possible, so we need to work on solutions to further reduce the bundle size, for example, supporting Preact or Nerv can help. +1. **Type checking**. We will continue to improve the TypeScript and possibly the Flow coverage of the library.