Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accordion] Summary secondary action #9993

Closed
1 task done
PLSFIX opened this issue Jan 22, 2018 · 4 comments
Closed
1 task done

[Accordion] Summary secondary action #9993

PLSFIX opened this issue Jan 22, 2018 · 4 comments
Labels
component: accordion This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@PLSFIX
Copy link

PLSFIX commented Jan 22, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

The same as ListItemSecondaryAction

Current Behavior

No (simple) ability to implement a secondary action

Context

Some quick-access-like actions from expansion panel's head.

Your Environment

Tech Version
Material-UI v1.0.0-beta.30
React 16
@oliviertassinari oliviertassinari added new feature New feature or request component: accordion This is the name of the generic UI component, not the React module! labels Jan 22, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 22, 2018

@PLSFIX We can reproduce this existing pattern:
https://github.com/mui-org/material-ui/blob/5831fe531d6b2256d65085400170ccf79fdd93cf/src/Table/TablePagination.js#L134-L141

An alternative is to have a renderActions() property.
I'm curious. Why is the children property not enough?

@PLSFIX
Copy link
Author

PLSFIX commented Jan 23, 2018

@oliviertassinari well, after some time i figured out how to implement this. Had to use e.stopPropagation() on child interactive element, therefore children property is enough.
On the other hand, we have Lists with it's ListItemSecondaryAction pattern, and I thought it could be more convenient to use the same pattern here, making it more standardized. By the way the same technique can be applied on Lists to.
Anyway, If you don't think the same way about it then this issue can be closed, thank you.

@oliviertassinari
Copy link
Member

@PLSFIX The ListItemSecondaryAction pattern sounds good too.

@eps1lon
Copy link
Member

eps1lon commented Jun 28, 2019

Closing in favor of the more active #9427.

@eps1lon eps1lon closed this as completed Jun 28, 2019
@oliviertassinari oliviertassinari changed the title [request] ExpansionPanelSummary secondary action [Accordion] Summary secondary action Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: accordion This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants