Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#963 broke build on Windows #992

Closed
alshain opened this issue Jun 29, 2015 · 6 comments · Fixed by #1039
Closed

#963 broke build on Windows #992

alshain opened this issue Jun 29, 2015 · 6 comments · Fixed by #1039
Labels
package: eslint Specific to eslint-plugin-material-ui support: question Community support but can be turned into an improvement

Comments

@alshain
Copy link
Contributor

alshain commented Jun 29, 2015

In package.json, ** is not supported by Windows' command line. Hence, the build broke with #963

@oliviertassinari
Copy link
Member

This patern was used before with jsxhint. Maybe some quotes are missing?

@alshain
Copy link
Contributor Author

alshain commented Jun 30, 2015

Before where and when? I've only been at this for a couple of days.

@codedance
Copy link

+1

Quoting does not seem to work. Reverting back the change in #963 (eslint src) works.

@oliviertassinari
Copy link
Member

@alshain Here c8f5f6d

@oliviertassinari
Copy link
Member

@codedance The problem with just src is that it's not linting everyfile. We can try src/*

@alshain
Copy link
Contributor Author

alshain commented Jun 30, 2015

No, that doesn't work either, it still says "no such file or directory" because it doesn't seem to expand the asterisk.

Why not create gulp tasks instead? Then you'd have globs that work across platforms.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added support: question Community support but can be turned into an improvement package: eslint Specific to eslint-plugin-material-ui and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: eslint Specific to eslint-plugin-material-ui support: question Community support but can be turned into an improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants