-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this.context.muiTheme is undefined with Tabs #867
Comments
@gerherz As far as I have understood they way you use ThemeManager is something like:
In your |
Yes, it's working fine with other components. I'm using ES6 with Babel, which allows me to use that syntax. It is equal to what you've wrote, as far as I know. |
Same thing is happening with Lists and ListItems. In React 0.14 this won't be an issue anymore, as they will stop using owner's context and replace it with the parent's context. |
@gerherz Have you seen #608 ? This could be a problem with multiple versions of react in your project. |
Thanks. I've finally upgraded to React 0.14 beta where this issue is solved. |
@gerherz how did you upgrade to React 0.14 Beta and not have conflicts with |
@shea256 not to mention react-router and pretty much any module that you are using right now. does anybody have themes working at all? |
@shea256 react-tab-event-plugin wasn't working for me on v0.13 and isn't working on v0.14 either. Take a look at this issue: zilverline/react-tap-event-plugin#22 The only problem I had was related to child contexts, which was changed on React v0.14 to parent context. |
I'm trying to use Tabs and getting this error message:
It seems as if the context wasn't being set in Tabs for its children.
This is the class that contains the Tabs component:
It extends from MuiComponent, which implements the getChildContext() requirement:
The text was updated successfully, but these errors were encountered: