Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog vertically centering #85

Closed
fabiozaffani opened this issue Nov 21, 2014 · 0 comments
Closed

Dialog vertically centering #85

fabiozaffani opened this issue Nov 21, 2014 · 0 comments
Labels
bug 🐛 Something doesn't work

Comments

@fabiozaffani
Copy link

The dialog only centers when the component are updated, this is hapenning because the calculation only happens in componentDidUpdate, and not when the component is mounted (componentDidMount).

I guess that a fix for that would be to create a new function specific to perform this calculation, and later calling this function from componentDidMount and componentDidUpdate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

2 participants