Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codemod] Error while running command pnpm tc badge-props and pnpm eslint #41501

Closed
skmanoj322 opened this issue Mar 15, 2024 · 3 comments
Closed
Assignees
Labels
component: badge This is the name of the generic UI component, not the React module! package: codemod Specific to @mui/codemod package: eslint Specific to eslint-plugin-material-ui status: waiting for author Issue with insufficient information

Comments

@skmanoj322
Copy link
Contributor

skmanoj322 commented Mar 15, 2024

Steps to reproduce

Link to live example: (required)

Steps:

  1. pnpm tc badge-props
    pnpm  tc badge-props

  2. pnpm eslint

eslintError

Current behavior

No response

Expected behavior

No response

Context

So i am contributing to badge-props . In codemod package they have mentioned to run pnpm tc <codemod> for final check.and it gave me an error as mentioned above.

so can anyone tell me the Expected behavior of these commands.

@sai6855 you have mentioned me to open pr and mention you there.
just for reference my pr of badge-props #41399

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: pnpm tc pnpm eslint

@skmanoj322 skmanoj322 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 15, 2024
@zannager zannager added component: badge This is the name of the generic UI component, not the React module! package: eslint Specific to eslint-plugin-material-ui labels Mar 15, 2024
@ZeeshanTamboli
Copy link
Member

@sai6855 Can you take a look? CC @DiegoAndai

@DiegoAndai
Copy link
Member

Hey @skmanoj322, did you pnpm install before running the commands?

If that doesn't fix it, may I ask you to try the following:

  1. Checkout the master branch: git checkout master
  2. Pull the upstream changes: git pull upstream master
  3. Checkout the feature branch: git checkout manoj/badge-v6-deprecations
  4. Merge master: git merge master
  5. Install dependencies: pnpm install
  6. Try commands again

I checked out your branch and ran the commands and they're working, so there must be some install or configuration missing.

@DiegoAndai DiegoAndai added status: waiting for author Issue with insufficient information package: codemod Specific to @mui/codemod and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 18, 2024
@DiegoAndai DiegoAndai changed the title Error while running command pnpm tc badge-props and pnpm eslint [codemod] Error while running command pnpm tc badge-props and pnpm eslint Mar 18, 2024
Copy link

Since the issue is missing key information and has been inactive for 7 days, it has been automatically closed. If you wish to see the issue reopened, please provide the missing information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: badge This is the name of the generic UI component, not the React module! package: codemod Specific to @mui/codemod package: eslint Specific to eslint-plugin-material-ui status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

4 participants