Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Material Icon search lags #41126

Closed
oliviertassinari opened this issue Feb 16, 2024 · 5 comments · Fixed by #41330 or #43569
Closed

[material-ui][docs] Material Icon search lags #41126

oliviertassinari opened this issue Feb 16, 2024 · 5 comments · Fixed by #41330 or #43569
Labels
docs Improvements or additions to the documentation package: icons Specific to @mui/icons performance

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 16, 2024

Steps to reproduce

Link to live example: (required)

Steps:

  1. Open https://mui.com/material-ui/material-icons/?query=alert
Screen.Recording.2024-02-16.at.01.21.13.mov

Current behavior

Main thread blocked

Expected behavior

No massive chunk of blocked time

Context

Google is aware of this problem, Chrome is feeding it back data about the page, see ahref INP data fetched from Google. Same data in https://pagespeed.web.dev/analysis/https-mui-com-material-ui-material-icons/253fjl9n29?form_factor=desktop

Horrible:
SCR-20240216-cexd

I would imagine that https://react.dev/reference/react/useTransition is the solution

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: Material Icon search lags

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation performance package: icons Specific to @mui/icons labels Feb 16, 2024
@danilo-leal danilo-leal added the package: material-ui Specific to @mui/material label Feb 16, 2024
@danilo-leal danilo-leal changed the title [docs] Material Icon search lags [material-ui][docs] Material Icon search lags Feb 16, 2024
@danilo-leal danilo-leal removed the package: material-ui Specific to @mui/material label Apr 24, 2024
@oliviertassinari
Copy link
Member Author

Reopen per #41330 (comment).

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 5, 2024

We seem to be in a much better state now on https://mui.com/material-ui/material-icons/ desktop using https://pagespeed.web.dev/.

Before this issue, February 16th, 2024:

Now, October 5th, 2024:

I'm curious about the impact of the latest PR we did will have. Let's report back in 30 days.

Copy link

github-actions bot commented Oct 5, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@aarongarciah
Copy link
Member

aarongarciah commented Oct 7, 2024

Have we tried leveraging content-visibility in the past? I've never used it, just wondering if it could be handy in this scenario if the rendering performance is one of the bottlenecks.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 8, 2024

@aarongarciah this property seems to help the browser with the "Rendering" phase of the pipeline. I'm not sure we had performance issues with this phase. We had issue with JavaScript time, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: icons Specific to @mui/icons performance
Projects
None yet
3 participants