Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown icon to list of Material Icon in MUI #38587

Open
2 tasks done
Here2Huynh opened this issue Aug 21, 2023 · 1 comment
Open
2 tasks done

Add markdown icon to list of Material Icon in MUI #38587

Here2Huynh opened this issue Aug 21, 2023 · 1 comment
Assignees
Labels
external dependency Blocked by external dependency, we can’t do anything about it package: icons Specific to @mui/icons

Comments

@Here2Huynh
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

I needed to use markdown icon as part of toggle button group, but could not find it in MUI's icon list (https://mui.com/material-ui/material-icons/?query=markdown). I tried making my own custom SVGIcon component, but that component doesn't have the on click features like the MUI icons out of the box. Perhaps I am missing something, but having the icon available is also nice.

Examples 🌈

https://squidfunk.github.io/mkdocs-material/reference/icons-emojis/

Uploading image.png…

Motivation 🔦

I am creating an editor for work and I need the markdown icon toggle button so user can toggle markdown mode in the editor

@Here2Huynh Here2Huynh added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 21, 2023
@mj12albert mj12albert added the package: icons Specific to @mui/icons label Aug 22, 2023
@mj12albert
Copy link
Member

@Here2Huynh Thanks for reporting this ~ we generally don't deviate from the official Material Design icons, see #34817 (comment)

I tried making my own custom SVGIcon component, but that component doesn't have the on click features

You also need to use it together with the IconButton component, here's a working sandbox: https://codesandbox.io/s/https-github-com-mui-material-ui-issues-38587-ylnpp4?file=/src/App.tsx

@mj12albert mj12albert added external dependency Blocked by external dependency, we can’t do anything about it and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependency Blocked by external dependency, we can’t do anything about it package: icons Specific to @mui/icons
Projects
None yet
Development

No branches or pull requests

3 participants