Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][useNumberInput] Warn when changing control mode with useControlled #38513

Closed
mj12albert opened this issue Aug 17, 2023 · 1 comment · Fixed by #38757
Closed

[base-ui][useNumberInput] Warn when changing control mode with useControlled #38513

mj12albert opened this issue Aug 17, 2023 · 1 comment · Fixed by #38757
Assignees
@mj12albert
Labels
component: number field This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature package: base-ui Specific to @mui/base

Comments

@mj12albert
Copy link
Member

Raised in #36119 (comment)

Pass the value/defaultValue through useControlled to warn against switching between uncontrolled to controlled.
@mj12albert mj12albert added package: base-ui Specific to @mui/base component: number field This is the name of the generic UI component, not the React module! labels Aug 17, 2023
@mj12albert mj12albert self-assigned this Aug 17, 2023
@mj12albert mj12albert mentioned this issue Sep 1, 2023
Merged
1 task
@sai6855 sai6855 mentioned this issue Sep 2, 2023
Merged
1 task
@oliviertassinari
Copy link
Member

@mj12albert Great, thanks for creating a GitHub issue. I should default to doing this.

@oliviertassinari oliviertassinari added the enhancement This is not a bug, nor a new feature label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mj12albert mj12albert

Labels
component: number field This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature package: base-ui Specific to @mui/base
Projects
Base UI Alpha
Archived in project
Joy UI
Status: Recently completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NumberInput][base-ui] Warn when changing control mode with useControlled sai6855/material-ui
2 participants
@oliviertassinari @mj12albert