Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FontIcon] inside an IconButton loose is color from props #3655

Closed
pradel opened this issue Mar 10, 2016 · 2 comments
Closed

[FontIcon] inside an IconButton loose is color from props #3655

pradel opened this issue Mar 10, 2016 · 2 comments
Labels
package: icons Specific to @mui/icons v0.x

Comments

@pradel
Copy link
Contributor

pradel commented Mar 10, 2016

FontIcon inside an IconButton loose is color from props

In material-ui.alpha.1 when you put a FontIcon with color props inside an IconButton the prop will not work.
I think is related to this commit a99451a

Before styles was merged like that:
this.mergeStyles({styles.root, style, { color: this.state.hovered ? onColor : offColor })

And now it is:
Object.assign({styles.root, style})

Versions

  • Material-UI: v0.15.0-alpha.1
  • React: 0.14.7
  • Browser: chrome 48.0.2564.116
@pradel pradel changed the title FontIcon inside an IconButton loose is color [FontIcon] inside an IconButton loose is color Mar 10, 2016
@pradel pradel changed the title [FontIcon] inside an IconButton loose is color [FontIcon] inside an IconButton loose is color from props Mar 10, 2016
@OshotOkill
Copy link

I found it too. I have to define colors with inline-style for the time being.

@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@aahan96
Copy link
Contributor

aahan96 commented Aug 15, 2016

Duplicate of #3577

@aahan96 aahan96 closed this as completed Aug 15, 2016
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added v0.x package: icons Specific to @mui/icons and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: icons Specific to @mui/icons v0.x
Projects
None yet
Development

No branches or pull requests

5 participants