Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] issue with left navigation (inline-styles-prefixer) #3613

Closed
divinetouch opened this issue Mar 7, 2016 · 2 comments
Closed

[Docs] issue with left navigation (inline-styles-prefixer) #3613

divinetouch opened this issue Mar 7, 2016 · 2 comments
Labels
bug 🐛 Something doesn't work external dependency Blocked by external dependency, we can’t do anything about it

Comments

@divinetouch
Copy link

I just forked the project today and tried to run the doc site on my local but keep getting error when trying to open the left navigation.

The error was thrown by the inline-style-prefixer library with the message Cannot read property 'indexOf' of null. Because I'm really new to this Material-UI project I don't know whether Material-UI fails to properly call the inline-style-prefixer APIs or inline-style-prefixer fails to properly check to make sure all the required params as not null or undefined.

There are two places that inline-styles-prefixer throw this error, flexboxIE.js and flexboxOld.js.

flexboxIE.js


if ((properties[property] || property === 'display' && value.indexOf('flex') > -1) && (browser === 'ie_mob' || browser === 'ie') && version == 10) {

flexboxOld.js

if ((properties[property] || property === 'display' && value.indexOf('flex') > -1) && (browser === 'firefox' && version < 22 || browser === 'chrome' && version < 21 || (browser === 'safari' || browser === 'ios_saf') && version <= 6.1 || browser === 'android' && version < 4.4 || browser === 'and_uc')) {

In both cases the error occurs when the property is _display_ but the value is _null_

To get rid of the error temporary and allow me to run the doc on my local I added the check for value : typeof value === 'string'.

Please let me know if this is purely inline-style-prefixer bug and I should open an issue with them instead.

versions

-Material-UI: 0.15.0-alpha.1

screen shot 2016-03-06 at 6 59 00 pm

@oliviertassinari
Copy link
Member

That should be fixed by robinweser/inline-style-prefixer#71.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation external dependency Blocked by external dependency, we can’t do anything about it bug 🐛 Something doesn't work and removed docs Improvements or additions to the documentation labels Mar 7, 2016
@tintin1343
Copy link
Contributor

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work external dependency Blocked by external dependency, we can’t do anything about it
Projects
None yet
Development

No branches or pull requests

3 participants