Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popover] rename popover-animation-from-top #2970

Closed
mbrookes opened this issue Jan 18, 2016 · 0 comments · Fixed by #3749
Closed

[Popover] rename popover-animation-from-top #2970

mbrookes opened this issue Jan 18, 2016 · 0 comments · Fixed by #3749
Labels
component: Popover The React component.

Comments

@mbrookes
Copy link
Member

The animation is vertical, but the direction depends on the anchor position, so it would make sense to rename the component to PopoverAnimationVertical during the transition to PascalCase (#1793).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: Popover The React component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Core] PascalCase component names, reorganise directory structure
2 participants
@mbrookes @zannager