Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableHeader has a null TableHeaderColumn if you set displaySelectAll to false #2948

Closed
suhail-ansari-apconic opened this issue Jan 15, 2016 · 0 comments
Closed

TableHeader has a null TableHeaderColumn if you set displaySelectAll to false #2948

suhail-ansari-apconic opened this issue Jan 15, 2016 · 0 comments
Labels
component: table This is the name of the generic UI component, not the React module!

Comments

@suhail-ansari-apconic
Copy link

As the above title suggests TableHeader will have an empty TableHeaderColumn even if you set displaySelectAll field to false.

I think the problem is line 155 of TableHeader.jsx

let children = [this._getSelectAllCheckboxColumn(props)];

Here the above called function return null if displaySelectAll is false rather the array should be empty IMHO.
@snyk-bot snyk-bot mentioned this issue May 24, 2021
Open
This was referenced Mar 13, 2022
Open
Open
Open
Open
Open
@zannager zannager added the component: table This is the name of the generic UI component, not the React module! label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nathanmarks @suhail-ansari-apconic @zannager