Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the ButtonBase component #2913

Closed
SukantGujar opened this issue Jan 13, 2016 · 5 comments
Closed

Expose the ButtonBase component #2913

SukantGujar opened this issue Jan 13, 2016 · 5 comments
Assignees
Labels
good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@SukantGujar
Copy link

Hi,

I am working on a weekend project and experimenting with material-ui. I am trying to implement a authentication menu using IconMenu component. The idea is simple and IconMenu seems to be a perfect match... display the sign-in/sign-out/user profile etc options in the menu and use the IconButton to show the user profile and name (in a tool tip). Much like what you have in GitHub :).

Initially the user is not signed in and I display a Font Icon inside the IconButton associated with the IconMenu. However, once the user has logged in, I want to display her profile image within the IconButton. For now I have used Avatar inside IconButton but doing that glitches the dimensions of the IconButton.
If IconButton can support images, I should be able to specify a fixed size on the IconButton and it will obey that if its displaying Font Icon or the image. Besides, the component should anyways support good old image based icons.

Thanks

@SukantGujar
Copy link
Author

So would there be a AvatarMenu too then? Instead of AvatarButton, it makes more sense IMHO, to extend Avatar/img support to IconButton. It is only natural to have image based icons.

@alitaheri alitaheri added the new feature New feature or request label Jan 14, 2016
@ivosabev
Copy link

+1 for ImageButton or IconButton with image support.

@Sharlaan
Copy link

Sharlaan commented Jun 21, 2016

+1 as well, i couldnot find any "natural" component housing an image as iconButton.
Had to search to discover the most approaching component to what i want is... an avatar XD
I'll do with it for now and remove its rounded corners & background:transparent ...
a src attribute to iconButton would be nice.

@michaellee8
Copy link

Any update on this one? I have met this problem too.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 28, 2017

I think that we can close that issue once we expose the ButtonBase component (it's internal right now).

@oliviertassinari oliviertassinari removed the new feature New feature or request label Jul 28, 2017
@oliviertassinari oliviertassinari changed the title IconButton should support Images. Expose the ButtonBase component Jul 28, 2017
@oliviertassinari oliviertassinari added the good first issue Great for first contributions. Enable to learn the contribution process. label Jul 30, 2017
@oliviertassinari oliviertassinari self-assigned this Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

No branches or pull requests

6 participants