Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive Nav #2738

Closed
leesei opened this issue Dec 31, 2015 · 5 comments
Closed

Responsive Nav #2738

leesei opened this issue Dec 31, 2015 · 5 comments
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process

Comments

@leesei
Copy link
Contributor

leesei commented Dec 31, 2015

Implementing responsive nav (a nav that is docked on large screen, float in small screen) is a painpoint.
The removal of PageWithNav makes the code easier to read (in master.jsx).
However that implementation depends on internal undocumented components.
Is there a suggested way detect break points in material-ui?
@oliviertassinari
Copy link
Member

I guess you want to implement something like #2721.
Well, IMHO, the LeftNav allow to do it easily. That would be a simple layout component.

@leesei
Copy link
Contributor Author

leesei commented Jan 1, 2016

Indeed, that's what I intended to be better documented/abstracted as a component.

@leesei
Copy link
Contributor Author

leesei commented Feb 4, 2016

Ping.

The main issue is break point detection in JS.
What do you reckon on users importing material-ui/lib/mixins directly in their app?

@newoga
Copy link
Contributor

newoga commented Feb 4, 2016

What do you reckon on users importing material-ui/lib/mixins directly in their app?

Don't do it please 😄 (#2437). For pretty much every mixin in material-ui/lib/mixins, there's probably a better way to do it in your own applications.

This feature request can be supported with components, but right now we're prioritizing code cleaning and stability over new features. Pull requests are welcome though!

@nathanmarks
Copy link
Member

Please refer to #3614 for a discussion on responsive helpers in the lib

@zannager zannager added the design: material This is about Material Design, please involve a visual or UX designer in the process label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@newoga @leesei @oliviertassinari @nathanmarks @zannager