Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Not able to install icons yarn add @material-ui/icons package #26240

Open
Santosh-13 opened this issue May 11, 2021 · 7 comments · Fixed by #26310
Open

[icons] Not able to install icons yarn add @material-ui/icons package #26240

Santosh-13 opened this issue May 11, 2021 · 7 comments · Fixed by #26310
Labels
new feature New feature or request package: icons Specific to @mui/icons performance

Comments

@Santosh-13
Copy link

Santosh-13 commented May 11, 2021

Current Behavior 😯

info There appears to be trouble with your network connection. Retrying...

Expected Behavior 🤔

Steps to Reproduce 🕹

Steps:

1.yarn add @material-ui/icons, showing network errors
image

Context 🔦

Your Environment 🌎

`npx @material-ui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @material-ui/envinfo` goes here.
@Santosh-13 Santosh-13 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 11, 2021
@Santosh-13 Santosh-13 changed the title icons Not able to install icons yarn add @material-ui/icons package May 11, 2021
@eps1lon eps1lon added new feature New feature or request package: icons Specific to @mui/icons and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 11, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented May 11, 2021

@Santosh-13 which version are you trying to install?

Duplicate of #12432?

@Santosh-13
Copy link
Author

Santosh-13 commented May 11, 2021

@oliviertassinari , #12432 (comment) has the fix in the discussion and it worked. I think this issue can be closed.

@Santosh-13
Copy link
Author

Thank you:)

@oliviertassinari
Copy link
Member

which version are you trying to install?

Looking at your screenshot, I conclude v4, which we haven't changed for a year.

@oliviertassinari
Copy link
Member

@eps1lon would you rather keep this issue open so we can talk about future improvements or close as a duplicate?

With developers keep struggling on v4, and v5 adding a good +30% more icons, it seems that we need to do something about it.

@eps1lon
Copy link
Member

eps1lon commented May 13, 2021

With developers keep struggling on v4, and v5 adding a good +30% more icons, it seems that we need to do something about it.

Agreed. I do have some ideas that should hopefully get us down to the v4 install size. Even going so far as just shipping ES modules since we no longer support node 10 but that's a bit more prone to bugs.

  • minify published icons code
  • Replace import * as React from 'react' with import of what we need (e.g. just import { Fragment } from 'react';
  • just ship ES modules

But that requires an update to the icons itself which aren't checked in. So first we need to update the icons (probably ignore the new ones) and then vendor in material-ui-icons/material-icons.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 10, 2021

#26310 was reverted in #26656 as it breaks Next.js.

@oliviertassinari oliviertassinari changed the title Not able to install icons yarn add @material-ui/icons package [icons] Not able to install icons yarn add @material-ui/icons package Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request package: icons Specific to @mui/icons performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants