Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Typography is dark text in dark mode #26008

Closed
2 tasks done
jqrun opened this issue Apr 28, 2021 · 3 comments
Closed
2 tasks done

[Docs] Typography is dark text in dark mode #26008

jqrun opened this issue Apr 28, 2021 · 3 comments
Labels
component: GlobalStyles The React component. duplicate This issue or pull request already exists

Comments

@jqrun
Copy link
Contributor

jqrun commented Apr 28, 2021

Noticed this while browsing the docs@next

https://next.material-ui.com/components/paper/

image

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.
@jqrun jqrun added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 28, 2021
@jqrun
Copy link
Contributor Author

jqrun commented Apr 28, 2021

Dug a little deeper and noticed all the Typography components were also rendering dark text in dark mode: https://next.material-ui.com/components/typography/, so I'll update the title of this bug accordingly

@jqrun jqrun changed the title [Docs] Some text in dark mode is still dark [Docs] Typography is dark text in dark mode Apr 28, 2021
@mnajdova
Copy link
Member

We depend on emotion-js/emotion#2334 for this to work. Here is a preview of the docs with that fix https://deploy-preview-25690--material-ui.netlify.app/components/typography/#main-content Looks like it works here. Can you confirm @jqrun?

@mnajdova mnajdova added bug 🐛 Something doesn't work component: GlobalStyles The React component. docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Apr 28, 2021
@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Apr 28, 2021
@oliviertassinari
Copy link
Member

Duplicate of #25458

@oliviertassinari oliviertassinari marked this as a duplicate of #25458 Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: GlobalStyles The React component. duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliviertassinari @mnajdova @jqrun