Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react version conflict #259

Closed
mukeshsoni opened this issue Jan 21, 2015 · 6 comments
Closed

react version conflict #259

mukeshsoni opened this issue Jan 21, 2015 · 6 comments
Labels
core Infrastructure work going on behind the scenes

Comments

@mukeshsoni
Copy link

react is specified as a dependency which result in multiple versions of react loaded and give me the following error

Uncaught TypeError: Cannot read property 'firstChild' of undefined

Shouldn't react be specified as a peerdependency and not dependency?

@hai-cea
Copy link
Member

hai-cea commented Jan 22, 2015

Could #194 have fixed this?

@banderson
Copy link

I ran into the same thing today, and running npm dedupe in the project directory resolved this. Probably not the long-term answer, but it should do the trick.

@klyngbaek
Copy link

I ran into the same thing today as well. I tried running npm dedupe as suggested by bdanderson, and that fixed it for me (for now) as well.

@EntilZha
Copy link

EntilZha commented Feb 6, 2015

Ditto on same error, with removing offending file/npm dedupe working.

@hai-cea
Copy link
Member

hai-cea commented Feb 13, 2015

In 0.7.0 we've changed react to a peer dependency. https://github.com/callemall/material-ui/blob/master/package.json#L36

Hopefully, this solves the issue.

@hai-cea hai-cea closed this as completed Feb 13, 2015
@SPY
Copy link

SPY commented Feb 14, 2015

i have the same trouble with 0.7.0 version and npm dedupe solved it.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added core Infrastructure work going on behind the scenes and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

No branches or pull requests

8 participants