Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leftNav not correctly hidden when width modified #2270

Closed
Tux1 opened this issue Nov 25, 2015 · 3 comments
Closed

leftNav not correctly hidden when width modified #2270

Tux1 opened this issue Nov 25, 2015 · 3 comments
Labels
bug 🐛 Something doesn't work

Comments

@Tux1
Copy link

Tux1 commented Nov 25, 2015

Hi All,

I wanted to increase width of a LeftNav component thanks to the prop style. However when you try to hide the LeftNav, a part of it is still visible because the component has not been moved enough on left.

I think it is because the new width is not correctly propagated into the component.

Cheers

@alitaheri alitaheri added the bug 🐛 Something doesn't work label Dec 5, 2015
@alitaheri
Copy link
Member

I think we should actually add a width prop to ensure it's clear enough. It will also reduce the change for bugs like this. @oliviertassinari What do you think?

@oliviertassinari
Copy link
Member

I agree.
Another would be to use style.width, but that's probably not the right way to do it.

@alitaheri
Copy link
Member

This was addressed in #2507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

3 participants