Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] Closing a dialog scrolls to the top of the page, on Gatsby website in Safari #21895

Closed
Floriferous opened this issue Jul 23, 2020 · 1 comment
Labels
status: waiting for author Issue with insufficient information

Comments

@Floriferous
Copy link
Contributor

I'm having a hard time tracking this one down, but for some reason, when I close a modal that has its trigger somewhere in the middle of a page, the scroll position resets to the top of the page.

This happens in a Gatsby website, and only in Safari.

I checked the activeElement right after this happens, and it's the #gatsby-focus-wrapper, not sure if that has something to do with it?

I don't believe we're doing anything fancy with scroll position on the page, so I could use some help to get to the root of this.

@Floriferous Floriferous added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 23, 2020
@oliviertassinari oliviertassinari added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 23, 2020
@oliviertassinari
Copy link
Member

The issue has been closed because it does not conform to our issue requirements.
Please provide a minimal reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

2 participants