Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog open vs isOpen #2128

Closed
rhythnic opened this issue Nov 11, 2015 · 4 comments
Closed

Dialog open vs isOpen #2128

rhythnic opened this issue Nov 11, 2015 · 4 comments
Labels
docs Improvements or additions to the documentation

Comments

@rhythnic
Copy link

In the doc examples, isOpen is used as a prop on Dialog. According to the docs, 'open' should be the prop and 'isOpen' is a method.
@oliviertassinari
Copy link
Member

Fixed by #2116. @shaurya947 Can we update the doc?

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Nov 11, 2015
@shaurya947
Copy link
Contributor

@oliviertassinari Yes, will do a patch release. Can you double check that other info on the Dialog page is accurate?

@oliviertassinari
Copy link
Member

I have just checked the raw example. It's fine. Regarding the patch, I would just add the relevant commit.

@shaurya947
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliviertassinari @shaurya947 @rhythnic