Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: should styled-components be mentioned in Customizing components? #21163

Closed
dandv opened this issue May 24, 2020 · 3 comments
Closed

docs: should styled-components be mentioned in Customizing components? #21163

dandv opened this issue May 24, 2020 · 3 comments
Labels
docs Improvements or additions to the documentation

Comments

@dandv
Copy link
Contributor

dandv commented May 24, 2020

At Customizing -> Components - 3. Specific variation, should the Styled components API be included?

It's also not quite clear if that API actually uses styled-components (with the bundle size implication, though I don't see that in package.json), or only uses its syntax.

@oliviertassinari
Copy link
Member

No, styled-components is an external dependency, for now.

@dandv
Copy link
Contributor Author

dandv commented May 24, 2020

The example reads import { styled } from '@material-ui/core/styles'; and I don't see styled-components in the package.json?

@oliviertassinari
Copy link
Member

Different implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

3 participants