Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript declaration merging (module augmentation) broken with colors/common/CommonColors #20208

Closed
hburrows opened this issue Mar 21, 2020 · 1 comment
Closed

Typescript declaration merging (module augmentation) broken with colors/common/CommonColors #20208

hburrows opened this issue Mar 21, 2020 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@hburrows
Copy link
Contributor

Now that CommonColors has changed from an exported Typescript interface to a non-exported type defined using Record<...> I can't figure out how to augment it with my own common colors and still make Typescript happy. Before merging #20079 (Display color preview in IntelliSense) this was straightforward with Typescript's declaration merging/module augmentation. Is this an oversight or should we not be "augmenting" theme.palette.common or am I not understanding how to make it work. Thanks in advance!!
@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Mar 21, 2020
@oliviertassinari
Copy link
Member

Duplicate of #20180

@oliviertassinari oliviertassinari marked this as a duplicate of #20180 Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hburrows @oliviertassinari