Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeView visibleNodes built incorrectly on re-render #20140

Closed
2 tasks done
tonyhallett opened this issue Mar 16, 2020 · 0 comments · Fixed by #20157
Closed
2 tasks done

TreeView visibleNodes built incorrectly on re-render #20140

tonyhallett opened this issue Mar 16, 2020 · 0 comments · Fixed by #20157
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!

Comments

@tonyhallett
Copy link
Contributor

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

After a re-render navigation is incorrect

Expected Behavior 🤔

Navigation works the same as it did before the re-render

Steps to Reproduce 🕹

https://codesandbox.io/s/mystifying-haze-4rwqx

Steps:

Normal behaviour

  1. Focus one
  2. Down arrow - two is focused

After re-render

  1. Click Toggle twice
  2. Focus one
  3. Down arrow - three is focused

I have mentioned why this is occurring and what appears to be the solution in this comment.
@oliviertassinari oliviertassinari added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Mar 16, 2020
@tonyhallett tonyhallett mentioned this issue Mar 18, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TreeView] Correct visibleNodes on re-render
2 participants
@oliviertassinari @tonyhallett