Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing components strings label props types to node type #1961

Closed
pandaiolo opened this issue Oct 22, 2015 · 3 comments
Closed

Changing components strings label props types to node type #1961

pandaiolo opened this issue Oct 22, 2015 · 3 comments
Labels
new feature New feature or request

Comments

@pandaiolo
Copy link
Contributor

This issue refers #1950 PR, that changed the prop type of card header title and subtitle to node intead of string to enable non-text values such as Links, Icons, etc.

Following the discussion on that PR, it seems that other components could also benefit from this change.

I am opening this issue to make an inventory of the places where it needs to be changed, so that I can make a PR with the related changes :

  • CardTitle title and subtitle
  • Tab label
  • GridTile title
  • Checkbox label , example: <span>Check that box to accept our <Link>TOS</Link></span>

Not sure :

  • DatePicker and TextField hintText and floatingLabelText
  • List subHeader
  • Snackbar action, message : would non-string content here break the Material Design specs ?
  • TableHeader tooltip

Misc notes :

  • Buttons label prop should stay string because nodes can be specified as children of the component to be used as the button label. Although the question of API consistency between components can be raised. (should all labels be node typed?)

So, what should be changed ? Thanks !

@isilweo
Copy link

isilweo commented Oct 27, 2015

I'm using node in CardHeader subtitle so probably both CardHeader title and subtitle should be changed also.

@pandaiolo
Copy link
Contributor Author

@isilweo this has been changed already in PR #1950

@isilweo
Copy link

isilweo commented Oct 27, 2015

Yes, sorry. My mistake.

@alitaheri alitaheri added this to the Composable Components milestone Dec 8, 2015
@alitaheri alitaheri added Type: Enhancement new feature New feature or request and removed Enhancement labels Dec 8, 2015
@alitaheri alitaheri modified the milestone: Composable Components Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants