Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] TablePagination responsive display issue #18561

Closed
pedroRelvas opened this issue Nov 25, 2019 · 9 comments · Fixed by #18668
Closed

[Table] TablePagination responsive display issue #18561

pedroRelvas opened this issue Nov 25, 2019 · 9 comments · Fixed by #18668
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@pedroRelvas
Copy link

Hi. There is a problem with the TablePagination. I've tried to fix it, but I'm not having success at all. Do you know how to fix it? This is a print on your website:
table_rows
Thanks.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. labels Nov 25, 2019
@oliviertassinari
Copy link
Member

@pedroRelvas Thanks for the report. I can reproduce, it seems that we could benefit from the following style:

diff --git a/packages/material-ui/src/TablePagination/TablePagination.js b/packages/material-ui/src/TablePagination/TablePagination.js
index cb2599303..7e70c7bdf 100644
--- a/packages/material-ui/src/TablePagination/TablePagination.js
+++ b/packages/material-ui/src/TablePagination/TablePagination.js
@@ -16,6 +16,7 @@ export const styles = theme => ({
   root: {
     color: theme.palette.text.primary,
     fontSize: theme.typography.pxToRem(14),
+    overflow: 'auto',
     // Increase the specificity to override TableCell.
     '&:last-child': {
       padding: 0,

Do you want to try the changes out? :)

@pedroRelvas
Copy link
Author

@oliviertassinari
It works! Thanks!

@oliviertassinari
Copy link
Member

Great. Do you want to submit a pull request?

@pedroRelvas
Copy link
Author

Yes!

@pedroRelvas
Copy link
Author

@oliviertassinari
remote: Permission to mui-org/material-ui.git denied to joseRelvasF3m.
fatal: unable to access 'https://github.com/mui-org/material-ui.git/': The requested URL returned error: 403

Can you give access to joseRelvasF3m?

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 25, 2019

@pedroRelvas You need to create a fork. Check our contribution guide.

@pedroRelvas
Copy link
Author

@oliviertassinari
I'm following the guide but I can't fork properly. This is the error:
duvida

@dantehemerson
Copy link

@pedroRelvas You are cloning with ssh, so You need add a ssh key to GIthub. You can add it following the next tutorial https://help.github.com/en/enterprise/2.17/user/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent

@oliviertassinari oliviertassinari changed the title TablePagination is not responsive [TablePagination] Responsive display issue Nov 30, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 30, 2019

@pedroRelvas You can use the GitHub web UI too, it can be simpler for a one-line change.

@oliviertassinari oliviertassinari changed the title [TablePagination] Responsive display issue [Table] TablePagination responsive display issue Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants