Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoComplete] Dropdown icon not centered-aligned when variant="filled" #18463

Closed
eyalito opened this issue Nov 20, 2019 · 2 comments · Fixed by #18520
Closed

[AutoComplete] Dropdown icon not centered-aligned when variant="filled" #18463

eyalito opened this issue Nov 20, 2019 · 2 comments · Fixed by #18520
Assignees
Labels
component: autocomplete This is the name of the generic UI component, not the React module!

Comments

@eyalito
Copy link

eyalito commented Nov 20, 2019

Current Behavior 😯

When AutoComplete has <TextField variant="filled ... />, dropdown icon is not centered-aligned. (screenshot from AutoComplete demo: https://codesandbox.io/s/material-demo-9zn53)
image

Expected Behavior 🤔

Dropdown icon is centered-align as in with <TextField variant="contained" ... />.
image

Steps to Reproduce 🕹

Steps:

  1. go to https://codesandbox.io/s/material-demo-9zn53
  2. select 'demo.js'
  3. set TextFiled's variant="filled"

Your Environment 🌎

Tech Version
Material-UI (core) v4.6.1
Material-UI (lab) v4.0.0-alpha.32
React v16.11.0
OS macOS 10.13.16
Browsers chrome 78.0.3904.97, firefox 70.0.1
@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Nov 20, 2019
@oliviertassinari
Copy link
Member

Thanks for the report. I'm surprised we didn't get it earlier. What do you think of the icon position with the Select component? We should be able to solve this issue with #18460 at the same time.

@eyalito
Copy link
Author

eyalito commented Nov 21, 2019

Thanks for the prompt answer.
The icon position of the Select component filled variant is inline with material design specs. It might be more aesthetic to have it centered-aligned with the selected value, once a value is selected. But that's only my aesthetics :)
The Autocomplete filled variant should probably also follow material design specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants