Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tab Demo] Item Three click leads to homepage #1569

Closed
quantizor opened this issue Sep 1, 2015 · 6 comments
Closed

[Tab Demo] Item Three click leads to homepage #1569

quantizor opened this issue Sep 1, 2015 · 6 comments
Labels
component: tabs This is the name of the generic UI component, not the React module!

Comments

@quantizor
Copy link

On the demo page for Tabs, clicking "Item Three" in the first set causes you be taken to the home screen.

ypkayb9pkr

@quantizor quantizor changed the title Item Three click leads to homepage [Tab Demo] Item Three click leads to homepage Sep 1, 2015
@oliviertassinari
Copy link
Member

Yes, the content of the second tab is Fair warning - the next tab routes to home!.
Maybe we should said the third

@quantizor
Copy link
Author

Hmm. Maybe change the tab text instead? If someone never goes to the second tab, that makes it look like a bug.

@shaurya947
Copy link
Contributor

@yaycmyk I like that idea. Would you care to submit a PR to make that change?

@quantizor
Copy link
Author

@shaurya947 Done #1775

@alitaheri
Copy link
Member

addressed in #1775

@shaurya947
Copy link
Contributor

Thank you @subjectix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

5 participants