Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] Change background color with out editing the theme's canvas colour? #1521

Closed
ghost opened this issue Aug 26, 2015 · 12 comments
Closed
Labels
component: dialog This is the name of the generic UI component, not the React module!

Comments

@ghost
Copy link

ghost commented Aug 26, 2015

Setting contentInnerStyle, contentStyle, or style = {{backgroundColor: "#ededed"}} doesn't seem to change it from white.

@jgoux
Copy link
Contributor

jgoux commented Nov 4, 2015

I'm also interested by this too. It's impossible to change even by adding a custom class.

@alitaheri alitaheri added the new feature New feature or request label Dec 8, 2015
@alitaheri alitaheri modified the milestone: 0.14.0 Release Dec 9, 2015
@oliviertassinari oliviertassinari removed this from the 0.14.0 Release milestone Dec 22, 2015
@beverlycodes
Copy link

I was hoping the style prop would work, but that oddly seems to change the overlayStyle instead.

@jcheroske
Copy link

I have just spent the last several hours plumbing the depths of the Dialog component. It appears that there is a direct child DIV of the 'content' DIV that is unreachable. None of the *style props target this element, but it has essential styles applied to it. These include the background color of the entire dialog, border radius and height.

@seanrankin
Copy link

Funny, we were looking for the same thing at the same time @jcheroske... I'm running down that rabbit hole myself today.

@seanrankin
Copy link

seanrankin commented Apr 26, 2016

Ok @jcheroske here's what I did:

// Declared a style with important...
.dialogRadiusHack > div:first-child {
  border-radius: 10px 10px 5px 5px !important;
}

//Set a custom style name on the dialog: 
contentClassName="dialogRadiusHack"

@mbrookes mbrookes added Enhancement and removed new feature New feature or request labels Apr 26, 2016
@mbrookes mbrookes reopened this Apr 26, 2016
@jcheroske
Copy link

!important wins the Internet yet again.

@oliviertassinari oliviertassinari added the component: dialog This is the name of the generic UI component, not the React module! label Dec 18, 2016
@mbrookes
Copy link
Member

Resolved by the new styling approach in next.

@idangozlan
Copy link

@mbrookes what is next?

@mbrookes
Copy link
Member

@hhsadiq
Copy link

hhsadiq commented Mar 3, 2017

@mbrookes can you tell little bit what is new styling approach. This was the link provided in README.md, but its no more working.

@Zuurkern
Copy link

Zuurkern commented Mar 4, 2017

@hhsadiq It's JSS with jss-theme-reactor

@georgelivas
Copy link

Work's in next with:
CSS:

.paper{
  background-color: rgba(255, 255, 255, 0.90) !important;
}

JS/React:

<Paper elevation={4} className='paper'>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests