Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] Add accessibility section in the documentation #13693

Closed
1 of 2 tasks
chedvac opened this issue Nov 26, 2018 · 1 comment
Closed
1 of 2 tasks

[Dialog] Add accessibility section in the documentation #13693

chedvac opened this issue Nov 26, 2018 · 1 comment
Assignees
Labels
accessibility a11y component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation priority: important This change can make a difference

Comments

@chedvac
Copy link

chedvac commented Nov 26, 2018

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

According to wai-aria guidelines, when dialog is fired - Initial focus should set on the first focusable element.

see on: https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/dialog.html

Current Behavior 😯

The focus is trapped on the dialog, but not set on the first element.
Need to press 'Tab' to focus to first element.

Your Environment 🌎

Tech Version
Material-UI v3.5.1
React v16.6.3
Browser chrome 70.0.3538.102
@oliviertassinari oliviertassinari added the component: dialog This is the name of the generic UI component, not the React module! label Nov 27, 2018
@oliviertassinari oliviertassinari changed the title Dialog - focus on first element [Dialog] Add accessibility section in the documentation Nov 27, 2018
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation priority: important This change can make a difference labels Nov 27, 2018
@oliviertassinari
Copy link
Member

According to wai-aria guidelines, when dialog is fired - Initial focus should set on the first focusable element.

@chedvac The specification mentions 4 different dialog focus strategy. Initial focus should set on the first focusable element is just one of them. I don't think that it's something we should enforce.

Now, I think that we miss an accessibility documentation section for the Dialog. I think that we should add one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation priority: important This change can make a difference
Projects
None yet
Development

No branches or pull requests

2 participants