Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material UI doesn't seem to work with Parcel #12413

Closed
2 tasks done
abilash13 opened this issue Aug 4, 2018 · 8 comments
Closed
2 tasks done

Material UI doesn't seem to work with Parcel #12413

abilash13 opened this issue Aug 4, 2018 · 8 comments
Labels
external dependency Blocked by external dependency, we can’t do anything about it

Comments

@abilash13
Copy link

  • This is a v1.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Material UI should work when using Parcel

Current Behavior

screen shot 2018-08-04 at 11 29 10 pm

/Users/abilash/wildwest/react-dump/parcel/node_modules/recompose/wrapDisplayName.js:3:37: Cannot resolve dependency '@babel/runtime/helpers/builtin/interopRequireDefault'
  1 | "use strict";
  2 |
 >3 | var _interopRequireDefault = require("@babel/runtime/helpers/builtin/interopRequireDefault");
    |                                      ^
  4 |
  5 | Object.defineProperty(exports, "__esModule", {
  6 |   value: true

Steps to Reproduce

Link:

  1. Following the same steps described in the sample parcel example given here: https://github.com/mui-org/material-ui/tree/master/examples/parcel

Context

I'm trying to use Material UI with Parcel and Babel

This is my .babelrc file:

{
  "presets": ["env", "react"],
  "plugins": ["transform-class-properties"]
}

Your Environment

Tech Version
@material-ui/core v1.4.3
react and react-dom v16.4.2
parcel-bundler v1.9.7
babel-preset-env 1.7.0
babel-preset-react 6.24.1
Browser Firefox
@dupski
Copy link

dupski commented Aug 4, 2018

This might be related to #12408

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 4, 2018

The error is coming from the recompose codebase. I doubt it's something wrong we do. It's most likely a parcel issue given it's working with the other bundlers. What do you think?

@oliviertassinari oliviertassinari added the external dependency Blocked by external dependency, we can’t do anything about it label Aug 4, 2018
@oliviertassinari
Copy link
Member

Do you want to open an issue on Parcel side?

@abilash13
Copy link
Author

Do you want to open an issue on Parcel side?

^ I have opened up an issue in the Parcel repo

It's most likely a parcel issue given it's working with the other bundlers. What do you think?

Yup sorry about that I was unsure where to file the issue.

@sakulstra
Copy link
Contributor

sakulstra commented Aug 5, 2018

Interestingly I got a similar error completely unrelated to parcel(isobuild):

  "@babel/runtime/helpers/builtin/interopRequireDefault" in /.../node_modules/@material-ui/core/styles/index.js (web.cordova)

I think this is related to the changes in the last babel release beta.56 https://github.com/babel/babel/releases/tag/v7.0.0-beta.56?

@mririgoyen
Copy link

This is not a Parcel issue. This is directly tied to the changes in the recompose package.

acdlite/recompose#723

They're blaming it on a change with babel. A workaround Material-UI can take is to downgrade their dependent use on recompose to 0.27.

@mbrookes
Copy link
Member

mbrookes commented Aug 6, 2018

I'd rather we wait for the (apparently imminent) downstream fix.

@oliviertassinari
Copy link
Member

Downstream fix seems OK, let's close for now. Thanks everybody.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependency Blocked by external dependency, we can’t do anything about it
Projects
None yet
Development

No branches or pull requests

6 participants