Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Native built-in search in select boxes #10972

Closed
1 task done
kobelobster opened this issue Apr 9, 2018 · 5 comments
Closed
1 task done

[Select] Native built-in search in select boxes #10972

kobelobster opened this issue Apr 9, 2018 · 5 comments
Labels
component: autocomplete This is the name of the generic UI component, not the React module!

Comments

@kobelobster
Copy link
Contributor

kobelobster commented Apr 9, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Context

Hi, for a feature we're developing right now we want to use select boxes that are searchable. I found this demo section: https://material-ui.com/demos/autocomplete/ where react-select KINDA does what we want, however the result design is different from what we want. We want the same style as the selectboxes from this repo AND we want to search in the opened select box, NOT where the label/selected value is.

Now I have two questions:

  1. Are there any plans to integrate that into this library and if not....
  2. Would a PR for this be accepted or is there a reason this is not implemented right now?

I ask because I forked this project, read the CONTRIBUTING.md and the first sentence was to check with the maintainers first, if a PR would be okay for a specific feature.

@mbrookes
Copy link
Member

mbrookes commented Apr 9, 2018

If by search you mean the way the native element supports it - focussing the first entry whose beginning that the entered characters match, then that seems like a sensible feature to support.

I don't believe it has been intentionally omitted.

@oliviertassinari any objections, or otherwise, any thoughts on implementation approach?

@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Apr 9, 2018
@oliviertassinari
Copy link
Member

It's a duplicate of #8191

@kobelobster
Copy link
Contributor Author

kobelobster commented Apr 10, 2018

There's a misunderstanding here.

I was not talking about simply entering letters and the search component automatically highlights a value, but instead that you can FILTER the list of the select

For example: Take this screenshot of an opened select box. You have a text field as "first entry" and if you enter something along the lines S235 only the second result would be displayed in the list, not ALL values.

@oliviertassinari or @mbrookes Would it be possible to reopen this?

image

@oliviertassinari oliviertassinari added out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) component: Autocomplete and removed duplicate This issue or pull request already exists out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) labels Apr 10, 2018
@oliviertassinari
Copy link
Member

@tzfrs Thanks for the clarification. It's something you should be able to build with any of the 3 different autocomplete libraries.

@kobelobster
Copy link
Contributor Author

I saw them, but they are doing it a bit different from the result I would expect. Anyway, I'm going to try it out if I can somehow get the result I want. I'll report back!

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants