Snackbar uses getDerivedStateFromProps() but also contains the following legacy lifecycles

[psamim]

Hi,

I get the two following errors in the console:

warning.js:33 Warning: Unsafe legacy lifecycles will not be called for components using new component APIs.

WithStyles(Snackbar) uses getDerivedStateFromProps() but also contains the following legacy lifecycles:
  componentWillReceiveProps
  componentWillUpdate

warning.js:33 Warning: Unsafe legacy lifecycles will not be called for components using new component APIs.

Snackbar uses getDerivedStateFromProps() but also contains the following legacy lifecycles:
  componentWillReceiveProps
  componentWillUpdate

Your Environment

Tech	Version
Material-UI	1.0.0-beta.39
React	16.3.0
browser	Chromium 65.0.3325.181

[oliviertassinari]

@psamim Thanks for raising this issue. I believe that these warnings shouldn't happen in the first place. The warnings are supposed to be suppressed:
https://github.com/reactjs/react-lifecycles-compat/blob/fd69fa09245545537caaf8b47861bab3e8549c6a/index.js#L45-L49 cc @bvaughn

I will work on #10793 today.

[bvaughn]

withStyles uses componentWillReceiveProps itself.

[oliviertassinari]

@bvaughn This logic is only here for react-hot-loader.
https://github.com/mui-org/material-ui/blob/924bc8c575b8c76f42ee7bf535778d14bcb8c21a/src/styles/withStyles.js#L118-L127
Commenting componentWillReceiveProps doesn't make the warnings go away

Commenting the getDerivedStateFromProps static function does.

[bvaughn]

Gotcha. Can you point me at a repro in Code Sandbox?

[oliviertassinari]

Alright, I went a bit deeper in this issue.

• I think that a large chunk of the warning can be explained by Support React 16.3 gaearon/react-hot-loader#918
• We really need to rely on ^2.5.0 of hoist-non-react-statics to get a correct behavior. Better support React 16.3.0 vercel/next.js#4090
• I'm gonna replace the withStyles().componentWillReceiveProps hook with withStyles.componentDidUpdate and force a re-rendering. [core] Work on React 16.3.0 support #10867

[psamim]

I am still getting the error even after updating to beta-40.

[oliviertassinari]

@psamim What's the warning?

[psamim]

Same as before, but it is also mentioning ButtonBase

[oliviertassinari]

@psamim Follow gaearon/react-hot-loader#918