Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSS is causing Flow errors #10738

Closed
1 task done
eluchsinger opened this issue Mar 20, 2018 · 4 comments
Closed
1 task done

JSS is causing Flow errors #10738

eluchsinger opened this issue Mar 20, 2018 · 4 comments
Labels
support: question Community support but can be turned into an improvement

Comments

@eluchsinger
Copy link
Contributor

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

No errors when using flow.

Current Behavior

I get a couple errors from the JSS library.
grafik

Context

This was a topic in JSS a couple days ago. Apparently it's fixed.
cssinjs/jss#411

If I install the dependencies with yarn, it will install jss version 9.8.0.

grafik

Your Environment

Tech Version
Material-UI 1.0.0-beta.38
React 16.2.0
browser not important
JSS 9.8.0
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 20, 2018

@eluchsinger How is this issue related to Material-UI?

@eluchsinger
Copy link
Contributor Author

Apparently that bug was fixed in [email protected]. Do you have to update the MUI npm package to update the dependency? Because it should be OK when I look into package.json.
https://github.com/mui-org/material-ui/blob/fd5d20332c5eac45ec2713113ae7f562ae1af95a/package.json#L79

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 20, 2018

@eluchsinger We keep the jss scope as wide as possible to avoid the duplication of the module in people bundle. 9.8.1 match our scope (^9.3.3). You need to update the version on your side. Either on your yarn.lock or package-lock.json.

@oliviertassinari oliviertassinari added the support: question Community support but can be turned into an improvement label Mar 20, 2018
@eluchsinger
Copy link
Contributor Author

Just for the record: I could update the resolved dependencies of material-ui (my local installation) by using the following command:
yarn upgrade material-ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support: question Community support but can be turned into an improvement
Projects
None yet
Development

No branches or pull requests

2 participants