[docs] Tweak code sizes #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladmoroz
commented
Nov 21, 2024
docs/src/fonts/index.css
Outdated
| /* Match 13px Unica to 11.5px Menlo */ | ||
| size-adjust: calc(100% * 11.5 / 13); | ||
| /* Match other monospace fonts to SF Mono in width */ | ||
| size-adjust: calc(100% * 13.25 / 14); |
There was a problem hiding this comment.
@colmtuite I realised I was looking at a much wider SF Mono while you were looking at a much narrower Menlo
Bumped it 7% larger, does it feel OK now or do you want to go larger?
There was a problem hiding this comment.
@vladmoroz I'd go a tiny bit larger still. Maybe 13.5px or something like that.
There was a problem hiding this comment.
Updated, have another look
https://deploy-preview-852--base-ui.netlify.app/new/components/dialog
Netlify deploy preview |
colmtuite
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-852--base-ui.netlify.app/new/components/dialog