[Popover] Don't stick upon click with openOnHover prop
#819
Conversation
Netlify deploy preview |
github-actions
bot
added
the
PR: out-of-date
|
Seems to work fine.
There's no prop exposed to control this behavior? |
Not currently but there could be. @vladmoroz |
atomiks
force-pushed
the
fix/Popover-openOnHover
branch
from
bb53509
to
0ff3752
Compare
github-actions
bot
removed
the
PR: out-of-date
|
I wouldn't want to add a prop unless necessary—is there a typical design where it makes sense to keep it open on click? |
Back when I was developing tippy.js, the "stick" behavior was actually the requested default (a while ago, 2019), and it wasn't configurable. I didn't hear of complaints. It's also the default in Floating UI now (working better with the recent fixes). |
| await user.hover(trigger); | ||
|
|
||
| // Closes instantly after opening due to `useClick` prop `stickIfOpen=false` | ||
| await act(async () => { | ||
| trigger.click(); | ||
| }); |
There was a problem hiding this comment.
Perhaps this is why it's configured by default, but it depends on the delay you use. If you happen to click <50ms after it opens coincidentally, it's pretty unexpected
The upgrade fixes bugs and adds this prop to turn off.