[collapsible][accordion] Add keepMounted prop
#807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
component: collapsible
Netlify deploy preview |
mj12albert
force-pushed
the
feat/collapsible/keep-mounted
branch
11 times, most recently
from
33cd50b
to
4778c4a
Compare
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
|
@colmtuite @vladmoroz Do you think it's an issue that 2 props are required to use hidden-until-found now? <Collapsible.Panel hiddenUntilFound keepMounted>
{/* content */}
</Collapsible.Panel> |
|
@mj12albert I think we should always mount the panel when |
|
If |
mj12albert
force-pushed
the
feat/collapsible/keep-mounted
branch
2 times, most recently
from
f57a122
to
11b782d
Compare
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
feat/collapsible/keep-mounted
branch
from
11b782d
to
f3362c7
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
feat/collapsible/keep-mounted
branch
3 times, most recently
from
f9f677f
to
06c64f4
Compare
mj12albert
commented
Nov 7, 2024
Comment on lines
116
to
118
| // toWarnDev doesn't work reliably with async rendering. To re-enable after it's fixed in the test-utils. | ||
| // eslint-disable-next-line mocha/no-skipped-tests | ||
| it.skip('warns when setting both `hiddenUntilFound` and `keepMounted={false}`', async function test() { |
There was a problem hiding this comment.
I tested this warning manually 😓
|
Updated ~ would appreciate a review @vladmoroz @michaldudak 🙏 |
mj12albert
force-pushed
the
feat/collapsible/keep-mounted
branch
5 times, most recently
from
277543f
to
42077e9
Compare
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
feat/collapsible/keep-mounted
branch
from
307c354
to
a07722b
Compare
github-actions
bot
added
PR: out-of-date
mj12albert
force-pushed
the
feat/collapsible/keep-mounted
branch
from
a07722b
to
28adc8a
Compare
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #728
We decided to default
keepMountedtofalsefor consistency with other components.Since
hiddenUntilFoundrequireskeepMounted={true}to work, using it will overridekeepMountedand show a warning in dev mode if bothhiddenUntilFoundandkeepMounted={false}are specified.