-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dialog][Modal] Remove disableBackdropClick #23607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
breaking change
component: dialog
This is the name of the generic UI component, not the React module!
component: modal
This is the name of the generic UI component, not the React module!
labels
Nov 18, 2020
eps1lon
changed the title
Feat/modal/slim down
[Dialog,Modal] Remove disableBackdropClick
Nov 18, 2020
eps1lon
commented
Nov 18, 2020
Comment on lines
-64
to
-65
disableBackdropClick | ||
disableEscapeKeyDown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They don't have any effect on next
either because we already have a fully custom onClose
in ConfirmationDialogRaw
oliviertassinari
changed the title
[Dialog,Modal] Remove disableBackdropClick
[Dialog][Modal] Remove disableBackdropClick
Nov 19, 2020
oliviertassinari
approved these changes
Nov 19, 2020
42 tasks
Shouldn't the example code still call |
@shiraze Please be specific. |
I think initial code examples by @eps1lon should be: Breaking changes
<Dialog
- disableBackdropClick
- onClose={handleClose}
+ onClose={(event, reason) => {
+ if (reason !== 'backdropClick') {
+ handleClose(event);
+ }
+ }}
/>
<Modal
- disableBackdropClick
- onClose={handleClose}
+ onClose={(event, reason) => {
+ if (reason !== 'backdropClick') {
+ handleClose(event);
+ }
+ }}
/> |
Yes, updated, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: dialog
This is the name of the generic UI component, not the React module!
component: modal
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
[Dialog] Remove the
disableBackdropClick
prop. It's redundant with thereason
argument.[Modal] Remove the
disableBackdropClick
prop. It's redundant with thereason
argument.disableEscapeKeyDown
is on the chopping block as well but will be handed separately.Also includes
onEscapeKeydown
migration guide as a follow-up to #23571Affected demos: