-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextareaAutosize] Fix height inconsistency for empty last row #20575
Merged
oliviertassinari
merged 2 commits into
mui:master
from
benwiley4000:textareaautosize-height
Apr 16, 2020
Merged
[TextareaAutosize] Fix height inconsistency for empty last row #20575
oliviertassinari
merged 2 commits into
mui:master
from
benwiley4000:textareaautosize-height
Apr 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: b17e685...a1ee887 Details of page changes
|
oliviertassinari
added
component: TextareaAutosize
The React component.
bug 🐛
Something doesn't work
labels
Apr 15, 2020
oliviertassinari
approved these changes
Apr 15, 2020
@benwiley4000 Thanks |
This was referenced Apr 20, 2020
This was referenced Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20574.
Note that I could possibly add a test for coverage, but I don't think the existing unit test suite would be a good place for that. The only way to really demo and fix the bug is in a browser, since it's the browser's layout engine which yields the problem.