-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TablePagination] Out of range warning when "count={-1}" #19874
[TablePagination] Out of range warning when "count={-1}" #19874
Conversation
No bundle size changes comparing 0033bb3...76d5dbf |
Thanks for taking the time. I don't think that a new test for this warning is something we should add on its own. However, I think that it tips us that we miss test coverage for a more important feature: the icons of the table pagination should work correctly with |
I messed some things, let me continue work on that |
packages/material-ui/src/TablePagination/TablePagination.test.js
Outdated
Show resolved
Hide resolved
@oliviertassinari , check it out, please |
packages/material-ui/src/TablePagination/TablePagination.test.js
Outdated
Show resolved
Hide resolved
packages/material-ui/src/TablePagination/TablePagination.test.js
Outdated
Show resolved
Hide resolved
@oliviertassinari @eps1lon Work in Progress :) sorry |
@dbarabashdev I have updated the test with the idea I had in mind. What do you think? Does it match the expectation you had? Thanks :) |
@oliviertassinari ahhh, yup, right I understood what do you mean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet :)
Hey,
I've added changes for TablePagination component if count value negative issue. Also, we should add a test interacting with the pagination icons when
count={-1}
, as @oliviertassinari wrote. We can wait for test and merge this PR or merge this one only with my changes.P.S I can add test but a bit later too :)
Closes #19865