[AvatarGroup] Add spacing prop #19761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponding to negative margin on avatar spacing Begin changes for spacing prop Change spacing to 4px increments with default -8px and add doc changes. Changing spacing from numerical to small, medium, and large spacing Update docs to reflect correct sizing
oliviertassinari
added
component: avatar
|
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% Details of bundle changes.Comparing: 61a9cc6...6b77702
|
|
@oliviertassinari Can you take a look when you get a chance? Should be good to go, but can't figure out why test_static or mui-org tests are failing. |
oliviertassinari
force-pushed
the
issue/18869-spacing
branch
from
8ee426e
to
9da49b3
Compare
oliviertassinari
force-pushed
the
issue/18869-spacing
branch
from
9da49b3
to
0ce81e0
Compare
|
@GFynbo The problem was the trailing spaces. I have also updated the logic to make CSS overrides of the spacing easier when the default value is used (inline style has more specificity). |
oliviertassinari
approved these changes
Feb 18, 2020
|
@GFynbo After looking at the output of the large variant, I think that small and medium are enough. |
oliviertassinari
force-pushed
the
issue/18869-spacing
branch
2 times, most recently
from
d9463e2
to
32f8b39
Compare
oliviertassinari
force-pushed
the
issue/18869-spacing
branch
from
32f8b39
to
6b77702
Compare
|
Alright, one step at the time, in any case, we can continue to iterate. I'm happy to discuss it further :). Well done! |
2 tasks
1 task
This was referenced Mar 21, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to issue:18869 with the enhancement of adding a spacing prop to the AvatarGroup lab component.
Add spacing prop with following options:
'small': -16'medium': -8'large': -4This should allow the users to manipulate the spacing between avatars without directly requiring more css changes. This PR adds this functionality.
e.g.