Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add hexToRgb rename to v3 to v4 changelog #19058

Merged
merged 3 commits into from
Jan 2, 2020

Conversation

zettca
Copy link
Contributor

@zettca zettca commented Jan 2, 2020

Closes #18995

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 2, 2020

No bundle size changes comparing 2a60cfc...e7bfb49

Generated by 🚫 dangerJS against e7bfb49

@oliviertassinari oliviertassinari changed the title Add hexToRgb rename to v3 to v4 changelog [docs] Add hexToRgb rename to v3 to v4 changelog Jan 2, 2020
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 2, 2020
@oliviertassinari oliviertassinari merged commit 9379fa8 into mui:master Jan 2, 2020
@oliviertassinari
Copy link
Member

@zettca It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@mbrookes
Copy link
Member

mbrookes commented Jan 3, 2020

This change implicitly suggest that the colorManipulator functions are public, when they aren't supposed to be. See: #13039.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 3, 2020

At this point, I think that they are public, we import them from the demos:
https://github.com/mui-org/material-ui/blob/d9ced3a2102c9e7441b15bb76d5d9bdbaf9391de/docs/src/pages/components/progress/CustomizedProgressBars.tsx#L2

A developer can do:

import { hexToRgb } from '@material-ui/core';

Side note. When is a module considered public? I think that when it's exported from the barrel index, which is the case.

@mbrookes
Copy link
Member

mbrookes commented Jan 3, 2020

Okay. It's a shame the fade name change wasn't applied first in that case. One for v5?

@oliviertassinari
Copy link
Member

I don't see what you are referring to. But no objection to consider changes for v5.

@mbrookes
Copy link
Member

mbrookes commented Jan 3, 2020

As per the issue linked from the comment you replied to earlier today: #13039 (comment)

@oliviertassinari
Copy link
Member

thanks, sounds great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document convertHexToRGB migration
4 participants