-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add hexToRgb rename to v3 to v4 changelog #19058
Conversation
No bundle size changes comparing 2a60cfc...e7bfb49 |
@zettca It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
This change implicitly suggest that the colorManipulator functions are public, when they aren't supposed to be. See: #13039. |
At this point, I think that they are public, we import them from the demos: A developer can do: import { hexToRgb } from '@material-ui/core'; Side note. When is a module considered public? I think that when it's exported from the barrel index, which is the case. |
Okay. It's a shame the fade name change wasn't applied first in that case. One for v5? |
I don't see what you are referring to. But no objection to consider changes for v5. |
As per the issue linked from the comment you replied to earlier today: #13039 (comment) |
thanks, sounds great |
Closes #18995