Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Add Czech and Slovak locales #18876

Merged
merged 4 commits into from
Dec 17, 2019
Merged

[l10n] Add Czech and Slovak locales #18876

merged 4 commits into from
Dec 17, 2019

Conversation

char0n
Copy link
Contributor

@char0n char0n commented Dec 16, 2019

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 16, 2019

No bundle size changes comparing 6ced014...ca459a1

Generated by 🚫 dangerJS against ca459a1

@char0n
Copy link
Contributor Author

char0n commented Dec 16, 2019

@honzajavorek can you pls have a quick look at this to verify my Czech skills ? ;]

@oliviertassinari oliviertassinari changed the title [i18n] Add Czech and Slovak traslation strings [l10n] Add Czech and Slovak locales Dec 16, 2019
@mbrookes
Copy link
Member

On hold Pending Czech review from @honzajavorek.

@mbrookes mbrookes added the on hold There is a blocker, we need to wait label Dec 17, 2019
@oliviertassinari
Copy link
Member

@mbrookes The alternative is to release it, if the translations are wrong, and if it's important, somebody will come and fix it?

@char0n
Copy link
Contributor Author

char0n commented Dec 17, 2019

I'm native speaker of both Slovak and Czech languages. So I'd say it's pretty safe to merge this PR. Just wanted to have somebody else like @honzajavorek have a look at this to verify I haven't done any spelling mistake.

@honzajavorek
Copy link

honzajavorek commented Dec 17, 2019 via email

Copy link

@honzajavorek honzajavorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "hvězdička" would be preferred over "hvězda" in the context of rating.

Also I spotted an extra whitespace, I'm not sure whether that is intended or not, but I don't see it in the other translations so I guess it's just a typo.

Otherwise 👍

packages/material-ui/src/locale/index.js Outdated Show resolved Hide resolved
packages/material-ui/src/locale/index.js Outdated Show resolved Hide resolved
packages/material-ui/src/locale/index.js Outdated Show resolved Hide resolved
Copy link

@honzajavorek honzajavorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️ ⭐️ ⭐️ ⭐️ ⭐️

@oliviertassinari oliviertassinari removed the on hold There is a blocker, we need to wait label Dec 17, 2019
@oliviertassinari oliviertassinari merged commit e5ab052 into mui:master Dec 17, 2019
@oliviertassinari
Copy link
Member

Thank you guys 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants