-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[l10n] Add Czech and Slovak locales #18876
Conversation
char0n
commented
Dec 16, 2019
- I have followed (at least) the PR section of the contributing guide.
No bundle size changes comparing 6ced014...ca459a1 |
@honzajavorek can you pls have a quick look at this to verify my Czech skills ? ;] |
On hold Pending Czech review from @honzajavorek. |
@mbrookes The alternative is to release it, if the translations are wrong, and if it's important, somebody will come and fix it? |
I'm native speaker of both Slovak and Czech languages. So I'd say it's pretty safe to merge this PR. Just wanted to have somebody else like @honzajavorek have a look at this to verify I haven't done any spelling mistake. |
I plan to look at it this afternoon, but I don’t expect to find anything
more than a random typo. Vladimir is 95% native Czech :)
…On Tue, 17 Dec 2019 at 08:11, Vladimir Gorej ***@***.***> wrote:
I'm native speaker of both Slovak and Czech languages. So I'd say it's
pretty safe to merge this PR. Just wanted to have somebody else like
@honzajavorek <https://github.com/honzajavorek> have a look at this to
verify I haven't done any spelling mistake.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18876>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACFGMO4A2LYBNVLSKBXG73QZB3SXANCNFSM4J3KIJNQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "hvězdička" would be preferred over "hvězda" in the context of rating.
Also I spotted an extra whitespace, I'm not sure whether that is intended or not, but I don't see it in the other translations so I guess it's just a typo.
Otherwise 👍
Co-Authored-By: Honza Javorek <[email protected]>
Co-Authored-By: Honza Javorek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐️ ⭐️ ⭐️ ⭐️ ⭐️
Thank you guys 🤗 |